Closed samdark closed 9 months ago
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ✔️ |
Parameter Renames for Clarity
Several parameter names were updated for better clarity. The previous parameters createNamespace
, createPath
, updateNamespaces
, and updatePaths
, have been renamed as newMigrationNamespace
, newMigrationPath
, sourceNamespaces
, and sourcePaths
respectively.
Updates in MigrationService Class
The MigrationService
class has been revised to accommodate these new parameter names.
Documentation Updates
The changes in parameter names were reflected in the documentation files usage-with-symfony.md
and usage-with-yii-console.md
.
Class Updates for New Parameter Names
Classes CreateCommand
, NewCommand
, UpdateCommand
, and MigrationService
were updated to use the new parameter names.
Test Additions and Updates
New tests were added and existing tests were updated for the CreateCommand
, UpdateCommand
, and MigrationService
classes to ensure the codebase remains robust with these changes.
Method Name Updates for Consistency
In line with the parameter renaming, certain method names were also updated: setCreatePath
and setUpdatePaths
are now setNewMigrationPath
and setSourcePaths
respectively, and setCreateNamespace
and setUpdateNamespaces
have been changed to setNewMigrationNamespace
and setSourceNamespaces
respectively.
Updated Method Calls
Method calls have been updated to reference the new method names, such as migrating from $migrationService->getCreateNamespace()
to $migrationService->getNewMigrationNamespace()
.
Attention: 8 lines
in your changes are missing coverage. Please review.
Comparison is base (
e0e4e49
) 97.34% compared to head (cdcc28a
) 97.34%.
Files | Patch % | Lines |
---|---|---|
config/di-console.php | 0.00% | 4 Missing :warning: |
config/params.php | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@arogachev fixed.