yiisoft / db

Yii Database Library
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
134 stars 35 forks source link

Fix CTE query expressions #761

Closed Tigrov closed 1 year ago

Tigrov commented 1 year ago
  1. Fix bug with Oracle when CTE aliases is not quoted.
  2. Fix bug with Oracle and MSSQL: RECURSIVE expression is not needed for CTE.

Related PRs

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -
what-the-diff[bot] commented 1 year ago

PR Summary

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (071f46a) 99.05% compared to head (d362637) 99.73%.

:exclamation: Current head d362637 differs from pull request most recent head 93ba140. Consider uploading reports for the commit 93ba140 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #761 +/- ## ============================================ + Coverage 99.05% 99.73% +0.68% - Complexity 1268 1272 +4 ============================================ Files 67 63 -4 Lines 3061 3056 -5 ============================================ + Hits 3032 3048 +16 + Misses 29 8 -21 ``` | [Files](https://app.codecov.io/gh/yiisoft/db/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/Query/Query.php](https://app.codecov.io/gh/yiisoft/db/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1F1ZXJ5L1F1ZXJ5LnBocA==) | `100.00% <100.00%> (ø)` | | | [src/QueryBuilder/AbstractDQLQueryBuilder.php](https://app.codecov.io/gh/yiisoft/db/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1F1ZXJ5QnVpbGRlci9BYnN0cmFjdERRTFF1ZXJ5QnVpbGRlci5waHA=) | `100.00% <100.00%> (ø)` | | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/yiisoft/db/pull/761/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

darkdef commented 1 year ago
  1. Fix bug with Oracle when CTE aliases is not quoted.

    1. Fix bug with Oracle and MSSQL: RECURSIVE expression is not needed for CTE.

Q A Is bugfix? ✔️ New feature? ❌ Breaks BC? ❌ Fixed issues -

Please add links to db-* PR's

Tigrov commented 1 year ago

Done