Closed Tigrov closed 1 year ago
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | #753 |
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
437c629
) 98.47% compared to head (17c924b
) 99.64%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Workflow Environment Variable Updates
In this pull request various workflow files were updated, specifically within the .github/workflows
directory. The changes relate to a modification in the environment variable COMPOSER_ROOT_VERSION
, which was updated to 1.2.0
from 1.0.0
. This change affects the versions used during CI/CD operations, aiming to improve compatibility and performance.
Bug Fix in CHANGELOG
Updates were made to the CHANGELOG.md
file, including a new bug fix under version 1.2.1
. The said bug fix resolves an issue (#777) related to the Query::count()
method, which inaccurately returned the count if the output exceeded PHP_INT_MAX
.
Improvement of Query.php Method
Modifications were made to the count()
method found in src/Query/Query.php
file to better manage situations where results surpass PHP_INT_MAX
. Now, instead of construing the count as an integer, it will transmit the count as a string in these scenarios, helping to maintain accuracy.
New Test Case
A fresh test case was added to the tests/AbstractQueryTest.php
file to check how the improved count()
method performs when the result exceeds PHP_INT_MAX
. The test sets up a pseudo instance of the Query
class and anticipates the queryScalar()
method to revert with a string value of 12345678901234567890
. Consequently, the revised count()
method is expected to return a string value in such cases, ensuring faithful representation of results.