search

yiisoft / event-dispatcher

PSR-14 event dispatcher
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
68 stars 22 forks source link

Rename ListenerCollection::add #81

Open xepozz opened 1 year ago

xepozz commented 1 year ago

It's better to rename the ListenerCollection::add method to ListenerCollection::withListener because it's not clear that it's immutable

samdark commented 1 year ago

That would be a BC-breaking change.

xepozz commented 1 year ago

Just mark it as deprecated and keep both until the next major version