yiisoft / html

Handy library to generate HTML
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
55 stars 17 forks source link

Add attributes to Html::ul and Html::ol (#174) #175

Closed AmolKumarGupta closed 8 months ago

AmolKumarGupta commented 8 months ago
Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues
what-the-diff[bot] commented 8 months ago

PR Summary

For instance, a test is performed to verify if Html::ul(['id' => 'main'])->items(Html::li('item 1'))->render() produces an 'unordered list' HTML tag, with id attribute as 'main' and includes a 'list item' HTML tag with the content as 'item 1'. Similar tests are performed for 'ordered list' HTML tags with 'id' attribute and content provided.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1657ad3) 100.00% compared to head (c01c2b8) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #175 +/- ## =========================================== Coverage 100.00% 100.00% - Complexity 760 762 +2 =========================================== Files 84 84 Lines 2053 2059 +6 =========================================== + Hits 2053 2059 +6 ``` | [Files](https://app.codecov.io/gh/yiisoft/html/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/Html.php](https://app.codecov.io/gh/yiisoft/html/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0h0bWwucGhw) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vjik commented 8 months ago

@AmolKumarGupta Thank you 👍