Add class for <hr> tag #191

yiisoft / html

Handy library to generate HTML

https://www.yiiframework.com/

BSD 3-Clause "New" or "Revised" License

55 stars 18 forks source link

Add class for <hr> tag #191 #192

Closed abdulmannans closed 6 months ago

abdulmannans commented 6 months ago

Q	A
New feature?	✔️
Fixed issues	#191

Test cases Passed

what-the-diff[bot] commented 6 months ago

PR Summary

Introduction of a New Hr Class A new class named Hr has been added. It's located in the src/Tag directory and extends the VoidTag class.
Addition of an HrTest Test Class We've also brought in a new test class called HrTest. It's lying in the tests/common/Tag directory and extends from TestCase. It’s purpose is to validate that invoking Hr::tag() returns a correct string representation of the HTML <hr> element (horizontal line).

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2398d1a) to head (5a92d95).

:exclamation: Current head 5a92d95 differs from pull request most recent head e59a734. Consider uploading reports for the commit e59a734 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #192 +/- ## =========================================== Coverage 100.00% 100.00% - Complexity 775 777 +2 =========================================== Files 85 86 +1 Lines 2098 2102 +4 =========================================== + Hits 2098 2102 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abdulmannans commented 6 months ago

@vjik Please check and let me know

abdulmannans commented 6 months ago

@vjik can you please review this?

vjik commented 6 months ago

@abdulmannans Thank you!