search

yiisoft / jquery-pjax

pushState + ajax = pjax
http://pjax.herokuapp.com
MIT License
144 stars 40 forks source link

Fix https://github.com/yiisoft/yii2/issues/2692 #4

Closed klevron closed 10 years ago

klevron commented 10 years ago

https://github.com/yiisoft/yii2/issues/2692

tonydspaniard commented 10 years ago

@qiangxue I confirm the solution works. IMHO we should also add a CHANGELOG file

qiangxue commented 10 years ago

Yes, please add a line to CHANGELOG.

@tonydspaniard Please feel free to merge a PR if you feel confident it is a correct fix. I'm not into pjax these days. So you are better than me to judge if a fix is correct or not.

tonydspaniard commented 10 years ago

@qiangxue Ok...

@klevron please add a CHANGELOG file with the bug fix if you don't mind before I can merge it.

klevron commented 10 years ago

OK

tonydspaniard commented 10 years ago

Thanks!

cebe commented 10 years ago

I think we should keep our own changelog for pjax and not track pjax changes in yii changelog.

samdark commented 10 years ago

Agree.