search

yiisoft / jquery-pjax

pushState + ajax = pjax
http://pjax.herokuapp.com
MIT License
143 stars 40 forks source link

Restore the last semicolon for Yii asset/compress #61

Closed tanakahisateru closed 6 years ago

tanakahisateru commented 6 years ago

Yii's asset/compress command cannot join JavaScripts they doesn't have semicolon at EOF correctly.

https://github.com/yiisoft/yii2/blob/1501c659aca7c50fa5e4f6fbe5ca549acc946c86/framework/console/controllers/AssetController.php#L571

So, I got these probrem with yii2-pjax 2.0.7:

no-semicolon 
)(jQuery)
/*** END FILE: jquery.pjax.js ***/
/*** BEGIN FILE: yii.activeForm.js ***/
(function($){

Above would be compressed as:

)(jQuery)(function($){

I expect:

)(jQuery);(function($){
samdark commented 6 years ago

Merged. Thanks!