yiisoft / rbac-db

yiisoft/db adapter for RBAC.
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
15 stars 7 forks source link

Add default table names #44

Closed arogachev closed 1 year ago

arogachev commented 1 year ago
Q A
Is bugfix?
New feature?
Breaks BC?
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.39% :warning:

Comparison is base (1a805a7) 99.42% compared to head (eccfd9b) 99.04%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #44 +/- ## ============================================ - Coverage 99.42% 99.04% -0.39% - Complexity 123 126 +3 ============================================ Files 9 9 Lines 518 521 +3 ============================================ + Hits 515 516 +1 - Misses 3 5 +2 ``` | [Files Changed](https://app.codecov.io/gh/yiisoft/rbac-db/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/AssignmentsStorage.php](https://app.codecov.io/gh/yiisoft/rbac-db/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0Fzc2lnbm1lbnRzU3RvcmFnZS5waHA=) | `100.00% <ø> (ø)` | | | [src/ItemsStorage.php](https://app.codecov.io/gh/yiisoft/rbac-db/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0l0ZW1zU3RvcmFnZS5waHA=) | `100.00% <ø> (ø)` | | | [src/DbSchemaManager.php](https://app.codecov.io/gh/yiisoft/rbac-db/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0RiU2NoZW1hTWFuYWdlci5waHA=) | `100.00% <100.00%> (ø)` | | | [src/ItemTreeTraversal/MysqlItemTreeTraversal.php](https://app.codecov.io/gh/yiisoft/rbac-db/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0l0ZW1UcmVlVHJhdmVyc2FsL015c3FsSXRlbVRyZWVUcmF2ZXJzYWwucGhw) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/yiisoft/rbac-db/pull/44/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

what-the-diff[bot] commented 1 year ago

PR Summary

These changes overall enhance the code's readability, maintainability, and consistency across various components of the system and between different types of databases. It will be easier to track and modify table names as they are now centrally referenced in the 'DbSchemaManager'.