Closed arogachev closed 1 year ago
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Enhancement of createItem
method in ItemsStorage.php
The method has been modified to improve its operation. The setting of $description
and $ruleName
on items is now dependent on whether they're filled or null, thereby ensuring unnecessary blanks are not set. So, it's essentially a change to make filling information on items more efficient and error free.
Removal and replacement of certain method chains
The withDescription
and withRuleName
methods that were initially used in the createItem
process have been eliminated. They've been replaced with conditional statements, thus streamlining the method and making it work better.
Introduction of a return statement at the method's end
To enhance visibility and traceability of changes, the updated createItem
method now concludes its operation by giving back the updated item. The change boosts tracking and clarity for any operations done on an item.
All modified lines are covered by tests :white_check_mark:
Comparison is base (
11b289b
) 96.18% compared to head (132c402
) 96.20%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.