search

yiisoft / rbac-db

yiisoft/db adapter for RBAC.
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
15 stars 6 forks source link

Fix path to migrations in readme #67

Closed vjik closed 9 months ago

vjik commented 9 months ago

implode(DIRECTORY_SEPARATOR, [dirname(__DIR__), 'vendor', 'yiisoft', 'rbac', 'migrations', 'assignments']),

1) incorrect path after vendor 2) replace to more simple dirname(__DIR__).'/vendor/yiisoft/...'

arogachev commented 9 months ago
  1. Where exactly the error is?
  2. Isn't using DIRECTORY_SEPARATOR more versatile?
samdark commented 9 months ago

implode() usage is less readable.

vjik commented 9 months ago
  • Where exactly the error is?

image

  • Isn't using DIRECTORY_SEPARATOR more versatile?

It's configuration for concrete case (often it will be Linux), versatile not need here. Also / work both for linux and windows.