yiisoft / router

Router is a request matcher and URL generator
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
59 stars 25 forks source link

Add `RouteArgument` attribute for Yii Hydrator #203

Closed vjik closed 9 months ago

vjik commented 1 year ago
Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues -
what-the-diff[bot] commented 1 year ago

PR Summary

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cd98ba6) 95.54% compared to head (39e3dad) 95.66%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #203 +/- ## ============================================ + Coverage 95.54% 95.66% +0.12% - Complexity 174 181 +7 ============================================ Files 14 16 +2 Lines 561 577 +16 ============================================ + Hits 536 552 +16 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xepozz commented 1 year ago

Why is it argument, isn't parameter better?

vjik commented 1 year ago

Why is it argument, isn't parameter better?

In router, this is called "arguments": https://github.com/yiisoft/router/blob/0892cbebfdfbe73ae9d2a64a133c96daf1552c7a/src/CurrentRoute.php#L112