yiisoft / translator

Message translation
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
23 stars 9 forks source link

Use BCP 47 formatted string for locale #103

Closed beastbytes closed 1 year ago

beastbytes commented 1 year ago
Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️/❌
what-the-diff[bot] commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3aead8d). Click here to learn what that means. Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #103 +/- ## ======================================== Coverage ? 3.38% Complexity ? 110 ======================================== Files ? 11 Lines ? 266 Branches ? 0 ======================================== Hits ? 9 Misses ? 257 Partials ? 0 ``` | [Impacted Files](https://codecov.io/gh/yiisoft/translator/pull/103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/SimpleMessageFormatter.php](https://codecov.io/gh/yiisoft/translator/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1NpbXBsZU1lc3NhZ2VGb3JtYXR0ZXIucGhw) | `0.00% <0.00%> (ø)` | | | [src/Translator.php](https://codecov.io/gh/yiisoft/translator/pull/103/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1RyYW5zbGF0b3IucGhw) | `0.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

darkdef commented 1 year ago

Sorry, but I don't agree. We use primarily the POSIX system, On POSIX platforms such as Unix, Linux and others, locale identifiers are defined by ISO/IEC 15897, which is similar to the BCP 47

darkdef commented 1 year ago

Read this https://en.wikipedia.org/wiki/Locale_(computer_software). Section about POSIX

samdark commented 1 year ago

@beastbytes First of all, tyanks for contributing. What's the idea behind the pull request? Would you please elaborate a bit?

samdark commented 1 year ago

Fixed in https://github.com/yiisoft/translator/pull/110. Thanks for reporting it.

darkdef commented 1 year ago

@beastbytes I'm so sorry. I don't understood you. We fixed that bug.