search

yiisoft / translator

Message translation
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
23 stars 9 forks source link

Make message formatter in category source optional + Increase MSI to 100% #76

Closed vjik closed 2 years ago

vjik commented 2 years ago
Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues -
codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 99.59% // Decreases project coverage by -0.40% :warning:

Coverage data is based on head (c489d19) compared to base (1cf49e0). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #76 +/- ## ============================================= - Coverage 100.00% 99.59% -0.41% Complexity 100 100 ============================================= Files 8 9 +1 Lines 245 246 +1 ============================================= Hits 245 245 - Misses 0 1 +1 ``` | [Impacted Files](https://codecov.io/gh/yiisoft/translator/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/CategorySource.php](https://codecov.io/gh/yiisoft/translator/pull/76/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0NhdGVnb3J5U291cmNlLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Translator.php](https://codecov.io/gh/yiisoft/translator/pull/76/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1RyYW5zbGF0b3IucGhw) | `100.00% <100.00%> (ø)` | | | [src/MessageReaderInterface.php](https://codecov.io/gh/yiisoft/translator/pull/76/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL01lc3NhZ2VSZWFkZXJJbnRlcmZhY2UucGhw) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

arogachev commented 2 years ago

Is BC break expected?

arogachev commented 2 years ago

Is BC break expected?

Discussed in group chat - it's OK.