yiisoft / user

Convenient user identity management and access checking.
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

#79 Move auto-login cookie params to component config parameters #80

Closed olegbaturin closed 11 months ago

olegbaturin commented 1 year ago
Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #79
what-the-diff[bot] commented 1 year ago

PR Summary

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 84.61% and project coverage change: -1.26% :warning:

Comparison is base (427a5ab) 88.44% compared to head (bdd4e4b) 87.18%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #80 +/- ## ============================================ - Coverage 88.44% 87.18% -1.26% - Complexity 95 98 +3 ============================================ Files 13 13 Lines 277 281 +4 ============================================ Hits 245 245 - Misses 32 36 +4 ``` | [Files Changed](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [config/di-web.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-Y29uZmlnL2RpLXdlYi5waHA=) | `0.00% <0.00%> (ø)` | | | [config/params.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-Y29uZmlnL3BhcmFtcy5waHA=) | `0.00% <0.00%> (ø)` | | | [src/CurrentUser.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0N1cnJlbnRVc2VyLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Event/AfterLogin.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0V2ZW50L0FmdGVyTG9naW4ucGhw) | `100.00% <100.00%> (ø)` | | | [src/Event/AfterLogout.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0V2ZW50L0FmdGVyTG9nb3V0LnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Event/BeforeLogin.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0V2ZW50L0JlZm9yZUxvZ2luLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Event/BeforeLogout.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0V2ZW50L0JlZm9yZUxvZ291dC5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Login/Cookie/CookieLogin.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0xvZ2luL0Nvb2tpZS9Db29raWVMb2dpbi5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Login/Cookie/CookieLoginMiddleware.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0xvZ2luL0Nvb2tpZS9Db29raWVMb2dpbk1pZGRsZXdhcmUucGhw) | `100.00% <100.00%> (ø)` | | | [src/Login/LoginMiddleware.php](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0xvZ2luL0xvZ2luTWlkZGxld2FyZS5waHA=) | `100.00% <100.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/yiisoft/user/pull/80?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

olegbaturin commented 1 year ago

Is php 7.4 support required for this package?

vjik commented 1 year ago

Is php 7.4 support required for this package?

No. If you want to raise PHP version to 8.0, please, create this in separate PR.

rustamwin commented 1 year ago

No. If you want to raise PHP version to 8.0, please, create this in separate PR.

Here is https://github.com/yiisoft/user/pull/58

olegbaturin commented 1 year ago

Is php 7.4 support required for this package?

No. If you want to raise PHP version to 8.0, please, create this in separate PR.

https://github.com/yiisoft/user/pull/78

This PR already requires to raise min php ver to 8.0.

vjik commented 1 year ago

@olegbaturin PHP version raised in master branch. You can merge master to your branch.