yiisoft / validator

Yii validator library
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
112 stars 39 forks source link

Corrections for PR #566 #569

Closed arogachev closed 1 year ago

arogachev commented 1 year ago
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

Corrections for PR #566.

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.90% // Head: 95.89% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (13b1ac3) compared to base (b83f79a). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## improve-each #569 +/- ## ================================================== - Coverage 95.90% 95.89% -0.02% + Complexity 726 724 -2 ================================================== Files 85 85 Lines 2199 2191 -8 ================================================== - Hits 2109 2101 -8 Misses 90 90 ``` | [Impacted Files](https://codecov.io/gh/yiisoft/validator/pull/569?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/Helper/PropagateOptionsHelper.php](https://codecov.io/gh/yiisoft/validator/pull/569?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0hlbHBlci9Qcm9wYWdhdGVPcHRpb25zSGVscGVyLnBocA==) | `100.00% <ø> (ø)` | | | [src/Helper/RulesNormalizer.php](https://codecov.io/gh/yiisoft/validator/pull/569?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0hlbHBlci9SdWxlc05vcm1hbGl6ZXIucGhw) | `100.00% <ø> (ø)` | | | [src/ValidatorInterface.php](https://codecov.io/gh/yiisoft/validator/pull/569?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1ZhbGlkYXRvckludGVyZmFjZS5waHA=) | `0.00% <ø> (ø)` | | | [src/Rule/Each.php](https://codecov.io/gh/yiisoft/validator/pull/569?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvRWFjaC5waHA=) | `84.09% <100.00%> (ø)` | | | [src/Rule/EachHandler.php](https://codecov.io/gh/yiisoft/validator/pull/569?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvRWFjaEhhbmRsZXIucGhw) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

arogachev commented 1 year ago

I tried to add support for null in rules, but it turned out that it is harder than I initially thought. Suggest to handle it later. Maybe it's not needed at all.