yiisoft / validator

Yii validator library
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
110 stars 36 forks source link

`Compare` - fix mutant and bug with using `>=` and `<=` operators with floats #578

Closed arogachev closed 1 year ago

arogachev commented 1 year ago
Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues
codecov[bot] commented 1 year ago

Codecov Report

Base: 94.65% // Head: 93.93% // Decreases project coverage by -0.73% :warning:

Coverage data is based on head (8aa9855) compared to base (19e9a26). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 8aa9855 differs from pull request most recent head c1244be. Consider uploading reports for the commit c1244be to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #578 +/- ## ============================================ - Coverage 94.65% 93.93% -0.73% - Complexity 723 725 +2 ============================================ Files 85 85 Lines 2188 2192 +4 ============================================ - Hits 2071 2059 -12 - Misses 117 133 +16 ``` | [Impacted Files](https://codecov.io/gh/yiisoft/validator/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/Rule/CompareHandler.php](https://codecov.io/gh/yiisoft/validator/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvQ29tcGFyZUhhbmRsZXIucGhw) | `100.00% <100.00%> (ø)` | | | [src/Rule/StopOnError.php](https://codecov.io/gh/yiisoft/validator/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvU3RvcE9uRXJyb3IucGhw) | `66.66% <0.00%> (-16.67%)` | :arrow_down: | | [src/Rule/Composite.php](https://codecov.io/gh/yiisoft/validator/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvQ29tcG9zaXRlLnBocA==) | `67.85% <0.00%> (-14.29%)` | :arrow_down: | | [src/Rule/Each.php](https://codecov.io/gh/yiisoft/validator/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvRWFjaC5waHA=) | `63.41% <0.00%> (-12.20%)` | :arrow_down: | | [src/Rule/Nested.php](https://codecov.io/gh/yiisoft/validator/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvTmVzdGVkLnBocA==) | `78.57% <0.00%> (-2.15%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

arogachev commented 1 year ago

@vjik Thanks! Fixed.