search

yiisoft / validator

Yii validator library
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
112 stars 39 forks source link

Skip empty iterable, allow 0 countable limit #586

Closed arogachev closed 1 year ago

arogachev commented 1 year ago
Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #431

Additional changes:

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.66% // Head: 94.68% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (33bcd4f) compared to base (e7105f3). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #586 +/- ## ============================================ + Coverage 94.66% 94.68% +0.01% - Complexity 725 726 +1 ============================================ Files 85 85 Lines 2192 2200 +8 ============================================ + Hits 2075 2083 +8 Misses 117 117 ``` | [Impacted Files](https://codecov.io/gh/yiisoft/validator/pull/586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/Rule/Each.php](https://codecov.io/gh/yiisoft/validator/pull/586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvRWFjaC5waHA=) | `75.60% <ø> (ø)` | | | [src/Rule/Required.php](https://codecov.io/gh/yiisoft/validator/pull/586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvUmVxdWlyZWQucGhw) | `100.00% <ø> (ø)` | | | [src/EmptyCondition/WhenEmpty.php](https://codecov.io/gh/yiisoft/validator/pull/586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0VtcHR5Q29uZGl0aW9uL1doZW5FbXB0eS5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Rule/Trait/CountableLimitTrait.php](https://codecov.io/gh/yiisoft/validator/pull/586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvVHJhaXQvQ291bnRhYmxlTGltaXRUcmFpdC5waHA=) | `88.13% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.