yiisoft / validator

Yii validator library
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
112 stars 39 forks source link

Fix `OneOf` and `AtLeast` messages #625

Closed arogachev closed 1 year ago

arogachev commented 1 year ago
Q A
Is bugfix?
New feature?
Breaks BC? ✔️
what-the-diff[bot] commented 1 year ago

PR Summary

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 97.53% and project coverage change: +0.10% :tada:

Comparison is base (def3a69) 94.30% compared to head (6dca8ba) 94.40%. Report is 3 commits behind head on master.

:exclamation: Current head 6dca8ba differs from pull request most recent head 3f6345f. Consider uploading reports for the commit 3f6345f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #625 +/- ## ============================================ + Coverage 94.30% 94.40% +0.10% - Complexity 749 775 +26 ============================================ Files 88 91 +3 Lines 2281 2358 +77 ============================================ + Hits 2151 2226 +75 - Misses 130 132 +2 ``` | [Files Changed](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/Rule/AtLeast.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvQXRMZWFzdC5waHA=) | `93.54% <0.00%> (-6.46%)` | :arrow_down: | | [src/Rule/IpHandler.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvSXBIYW5kbGVyLnBocA==) | `100.00% <ø> (ø)` | | | [src/Rule/AbstractNumber.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvQWJzdHJhY3ROdW1iZXIucGhw) | `100.00% <100.00%> (ø)` | | | [src/Rule/AtLeastHandler.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvQXRMZWFzdEhhbmRsZXIucGhw) | `100.00% <100.00%> (ø)` | | | [src/Rule/Email.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvRW1haWwucGhw) | `100.00% <100.00%> (ø)` | | | [src/Rule/OneOf.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvT25lT2YucGhw) | `100.00% <100.00%> (ø)` | | | [src/Rule/OneOfHandler.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvT25lT2ZIYW5kbGVyLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Rule/Regex.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvUmVnZXgucGhw) | `100.00% <100.00%> (ø)` | | | [...rc/Rule/Trait/TranslatedAttributesHandlerTrait.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvVHJhaXQvVHJhbnNsYXRlZEF0dHJpYnV0ZXNIYW5kbGVyVHJhaXQucGhw) | `100.00% <100.00%> (ø)` | | | [src/Rule/Url.php](https://app.codecov.io/gh/yiisoft/validator/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvVXJsLnBocA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samdark commented 1 year ago

👍