yiisoft / validator

Yii validator library
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
110 stars 36 forks source link

Disallow `$min` greater than amount of `$attributes` in `AtLeast` configuration #626

Closed arogachev closed 10 months ago

arogachev commented 10 months ago
Q A
Is bugfix?
New feature?
Breaks BC?
what-the-diff[bot] commented 10 months ago

PR Summary

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4e79a26) 94.40% compared to head (05f6247) 94.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #626 +/- ## ========================================= Coverage 94.40% 94.40% - Complexity 775 776 +1 ========================================= Files 91 91 Lines 2358 2359 +1 ========================================= + Hits 2226 2227 +1 Misses 132 132 ``` | [Files Changed](https://app.codecov.io/gh/yiisoft/validator/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/Rule/AtLeast.php](https://app.codecov.io/gh/yiisoft/validator/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1J1bGUvQXRMZWFzdC5waHA=) | `93.75% <100.00%> (+0.20%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samdark commented 10 months ago

👍