Closed arogachev closed 7 months ago
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ✔️ |
Attention: 30 lines
in your changes are missing coverage. Please review.
Comparison is base (
493a2d1
) 94.45% compared to head (76fb3ff
) 12.30%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request includes a series of updates and enhancements which primarily involve changes related to the renaming of the RuleWithOptionsInterface
interface to DumpedRuleInterface
. These changes have been rolled out across many files and code segments.
Adjustment to validation rules
The validation rule name length
has been updated to Yiisoft\Validator\Rule\Length
for higher accuracy.
Change in rule interfaces
The RuleWithOptionsInterface
interface has been renamed as DumpedRuleInterface
. This is reflected in multiple files where the old interface was imported. The files ranging from rule definitions (e.g., at-least.php
, boolean-value.php
, etc.) to tests (e.g., compare.php
, email.php
, etc.) all now use the new DumpedRuleInterface
.
Update in processing method
In rules-dumper.php
, the method for fetching options has been updated, now it handles instances of DumpedRuleInterface
instead of the previous RuleWithOptionsInterface
.
Removal of getName()
method
The method getName()
was removed from Yaml
and RgbColor
classes, and consequently from RuleInterface
. This has also led to the removal or alteration of this method in several test cases and classes.
Test classes now use class names instead of string names
Some test cases in RulesDumperTest
now use explicit class reference (like Integer
, BooleanValue
, and Required
) instead of string names.
Addition of getName()
method to multiple test classes
Numerous test classes (like BooleanValueTest
, CallbackTest
, CompareTest
, etc.) now contain the getName()
method that returns the class name for better identification.
Replacement of string rule names with class constants In various test files, string rule names have been substituted by class constants for more robust referencing.
These changes aim to improve the readability and stability of the codebase.