yiisoft / validator

Yii validator library
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
110 stars 36 forks source link

Move out `getName()` from `RuleInterface` #640

Closed arogachev closed 7 months ago

arogachev commented 7 months ago
Q A
Is bugfix?
New feature?
Breaks BC? ✔️
codecov[bot] commented 7 months ago

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (493a2d1) 94.45% compared to head (76fb3ff) 12.30%. Report is 1 commits behind head on master.

Files Patch % Lines
src/Rule/JsonHandler.php 0.00% 4 Missing :warning:
src/Helper/RulesDumper.php 0.00% 2 Missing :warning:
src/Rule/AbstractCompare.php 0.00% 2 Missing :warning:
src/Rule/AbstractNumber.php 0.00% 2 Missing :warning:
src/Rule/AtLeast.php 0.00% 1 Missing :warning:
src/Rule/BooleanValue.php 0.00% 1 Missing :warning:
src/Rule/Callback.php 0.00% 1 Missing :warning:
src/Rule/Composite.php 0.00% 1 Missing :warning:
src/Rule/Count.php 0.00% 1 Missing :warning:
src/Rule/Each.php 0.00% 1 Missing :warning:
... and 14 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #640 +/- ## ============================================= - Coverage 94.45% 12.30% -82.15% + Complexity 776 770 -6 ============================================= Files 91 90 -1 Lines 2361 2348 -13 ============================================= - Hits 2230 289 -1941 - Misses 131 2059 +1928 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

what-the-diff[bot] commented 7 months ago

PR Summary

This pull request includes a series of updates and enhancements which primarily involve changes related to the renaming of the RuleWithOptionsInterface interface to DumpedRuleInterface. These changes have been rolled out across many files and code segments.

These changes aim to improve the readability and stability of the codebase.