yiisoft / view

Yii view rendering library
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
56 stars 44 forks source link

Add `ViewTrait::addToArrayParameter()` and more tests #194

Closed vjik closed 2 years ago

vjik commented 2 years ago
Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues -

For example, this method will be useful for breadcrumbs:

// Add in view
$this->addToArrayParameter('breadcrumbs', $item1, $item2);

// Get in layout
$breadcrumbs = $this->getParameter('breadcrumbs') ?? [];
samdark commented 2 years ago

How about making parameters a collection instead?

// Add in view
$this->parameters()->add('breadcrumbs', $item1, $item2);

// Get in layout
$breadcrumbs = $this->parameters()->get('breadcrumbs') ?? [];
samdark commented 2 years ago

It will break BC though...

samdark commented 2 years ago

👍