yiisoft / view

Yii view rendering library
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
56 stars 44 forks source link

Template #231

Open rustamwin opened 1 year ago

rustamwin commented 1 year ago
Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any
what-the-diff[bot] commented 1 year ago

PR Summary

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d211ca6) 99.74% compared to head (84223fd) 99.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #231 +/- ## ========================================= Coverage 99.74% 99.75% - Complexity 299 304 +5 ========================================= Files 18 19 +1 Lines 791 803 +12 ========================================= + Hits 789 801 +12 Misses 2 2 ``` | [Impacted Files](https://app.codecov.io/gh/yiisoft/view/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/PhpTemplateRenderer.php](https://app.codecov.io/gh/yiisoft/view/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1BocFRlbXBsYXRlUmVuZGVyZXIucGhw) | `100.00% <100.00%> (ø)` | | | [src/Template.php](https://app.codecov.io/gh/yiisoft/view/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1RlbXBsYXRlLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/ViewTrait.php](https://app.codecov.io/gh/yiisoft/view/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1ZpZXdUcmFpdC5waHA=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

samdark commented 1 year ago

Good refactoring but doesn't solve any current issues and is backwards incompatible. Will hold it for now.