Closed Gerych1984 closed 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5f6e579
) 98.46% compared to head (0b56bf7
) 98.61%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Simplification of Alert.php
The Alert.php
file was revised for a more streamlined approach. We introduced a new, efficient method for rendering content while also discarding some unnecessary methods and properties.
Trait Introduction in AbstractCloseButtonWidget.php
The class was transformed into trait and renamed from AbstractCloseButtonWidget.php
to CloseButtonTrait.php
. This was done to help increase code reusability across different files. Some methods have been updated and new methods have been added.
Incorporation of CloseButtonTrait in Various Files
The Modal.php
, Offcanvas.php
, and Toast.php
files now utilize CloseButtonTrait
. This, together with modifications in existing methods, simplifies their structure and makes them easier to maintain, removing unnecessary redundancies.
Improvements in Testing
The test files AlertTest.php
, ModalTest.php
, and ToastTest.php
were overhauled to reflect all the changes made in the main files. These adjustments will ensure our tests are reliable and up-to-date with our current codebase.
In brief, this PR brings improvements in code maintainability, reusability, and testing.
Since last PR I forgot about
Alert
andToast
, which have a close button but no toggle, soAbstractCloseButton
moved toCloseButtonTrait
.Offcanvas
andModal
now extended fromAbstractToggleWidget
Offcanvas
,Modal
,Alert
andToast
now useCloseButtonTrait