yiisoft / yii-bootstrap5

Yii Framework Bootstrap 5 support
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
60 stars 20 forks source link

Close button trait #130

Closed Gerych1984 closed 8 months ago

Gerych1984 commented 8 months ago
Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️

Since last PR I forgot about Alert and Toast, which have a close button but no toggle, soAbstractCloseButton moved to CloseButtonTrait.

  1. Offcanvas and Modal now extended from AbstractToggleWidget
  2. Offcanvas, Modal, Alert and Toast now use CloseButtonTrait
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5f6e579) 98.46% compared to head (0b56bf7) 98.61%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ============================================ + Coverage 98.46% 98.61% +0.15% + Complexity 497 493 -4 ============================================ Files 21 21 Lines 1692 1660 -32 ============================================ - Hits 1666 1637 -29 + Misses 26 23 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

what-the-diff[bot] commented 8 months ago

PR Summary

In brief, this PR brings improvements in code maintainability, reusability, and testing.