Closed vjik closed 9 months ago
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ✔️ |
This PR implements a range of modifications across various files, mainly focusing on revising ID attributes and removing counter methods from test files. Here is an overview of the changes made:
Simplified ID assignment in multiple files
In Button.php
, Carousel.php
, Nav.php
, and Progress.php
, the process to generate an ID has been simplified, resulting in cleaner and more straightforward IDs for elements.
Improved code readability in NavBar.php
The comment documentation in NavBar.php
has been slightly adjusted to enhance readability and comprehension of the code.
Streamlined methods in Widget.php
Adjustments have been made to the getId
method in Widget.php
to make it much simpler and more efficient to use.
Updated IDs in Test files
The IDs in AccordionTest.php
, AlertTest.php
, along with several other test files, are now set to 'test', making it easier to carry out tests on these elements.
Removed counter methods from tests
In numerous test files such as BreadcrumbsTest.php
, ButtonDropdownTest.php
, etc., specific counter methods with the format ClassName::counter(0)
have been removed, making the code cleaner and more readable.
Added specific 'test' IDs in CarouselTest.php and several other Test files
In the CarouselTest.php
file and many others, a 'test' ID has been added to individual elements, making it easier to conduct testing activities.
All of these changes aim to make the codebase cleaner, easier to navigate, and more manageable without impacting its primary functions. These modifications should improve development efficiency moving forward.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6afc7c7
) 98.61% compared to head (bf0cfea
) 98.37%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.