yiisoft / yii-dataview

Data widgets
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
39 stars 21 forks source link

Update OffsetPagination.php #178

Closed aphraoh closed 8 months ago

aphraoh commented 8 months ago

In OffsetPagination, no way of setting private member variables $labelPrevious, $labelNext, $labelFirst, $labelLast (Issue #177)

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
what-the-diff[bot] commented 8 months ago

PR Summary

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 64.92%. Comparing base (7b94884) to head (d732582).

:exclamation: Current head d732582 differs from pull request most recent head 39a6de4. Consider uploading reports for the commit 39a6de4 to get more accurate results

Files Patch % Lines
src/OffsetPagination.php 0.00% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #178 +/- ## ============================================ - Coverage 65.49% 64.92% -0.58% - Complexity 543 547 +4 ============================================ Files 46 46 Lines 1820 1836 +16 ============================================ Hits 1192 1192 - Misses 628 644 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vjik commented 8 months ago

Thank you!