search

yiisoft / yii-dataview

Data widgets
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
38 stars 22 forks source link

Inconsistent numbering of pages in LinkPager #28

Closed cebe closed 2 weeks ago

cebe commented 9 years ago

LinkPager shows page number starting from 1 and urls generated by Pagination are also 1 based. However the data Html attribute is 0 based:

https://github.com/yiisoft/yii2/blob/master/framework/widgets/LinkPager.php#L213

Is there a specific reason for this? Imo this should be adjusted to be constitent.

samdark commented 9 years ago

I don't think there's any reason for it.

samdark commented 2 weeks ago

Not applicable to Yii3.