Remove generators from params

yiisoft / yii-gii

Yii code generator extension

https://www.yiiframework.com/

BSD 3-Clause "New" or "Revised" License

33 stars 17 forks source link

Remove generators from params #115

Closed vjik closed 9 months ago

vjik commented 9 months ago

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues	-

Instances of generators creates before create Gii instance (see config di.php). But generators contain dependencies, which may not exist in app. It's leads to errors.

For example, ActiveRecord\Generator require ConnectionInterface, but demo app don't use Yii DB.

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (d0be050) 39.72% compared to head (76e2982) 39.72%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #115 +/- ## ========================================= Coverage 39.72% 39.72% Complexity 224 224 ========================================= Files 33 33 Lines 871 871 ========================================= Hits 346 346 Misses 525 525 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

what-the-diff[bot] commented 9 months ago

PR Summary

Removal of Unused Dependencies The config/params.php file was tweaked, removing an unnecessary reference (the use statement) to the Yiisoft\Yii\Gii\Generator. This is integral as it could help enhance code maintainability by reducing clutter.
Configuration Adjustment The generators array under the 'yiisoft/yii-gii' section has been cleared. This simplification makes the code more straightforward and could contribute to easier future adjustments.