CHtml::activeLabel and tabular input

[pavimus]

currently activeLabel generates wrong label for tabular input if 'for' html option specified. It generates something '[0]value' instead 'Value'. To fix this problem, CHtml::activeLabel must be changed from

    public static function activeLabel($model,$attribute,$htmlOptions=array())
    {
        if(isset($htmlOptions['for']))
        {
            $for=$htmlOptions['for'];
            unset($htmlOptions['for']);
        }
        else  {
            $for=self::getIdByName(self::resolveName($model,$attribute));
        }
        if(isset($htmlOptions['label']))
        {
            if(($label=$htmlOptions['label'])===false)
                return '';
            unset($htmlOptions['label']);
        }
        else {
            $label=$model->getAttributeLabel($attribute);
        }
        if($model->hasErrors($attribute))
            self::addErrorCss($htmlOptions);

        return self::label($label,$for,$htmlOptions);
    }

to

    public static function activeLabel($model,$attribute,$htmlOptions=array())
    {
        $name=self::resolveName($model,$attribute);
        if(isset($htmlOptions['for']))
        {
            $for=$htmlOptions['for'];
            unset($htmlOptions['for']);
        }
        else  {
            $for=self::getIdByName($name);
        }
        if(isset($htmlOptions['label']))
        {
            if(($label=$htmlOptions['label'])===false)
                return '';
            unset($htmlOptions['label']);
        }
        else {
            $label=$model->getAttributeLabel($attribute);
        }
        if($model->hasErrors($attribute))
            self::addErrorCss($htmlOptions);

        return self::label($label,$for,$htmlOptions);
    }

[klimov-paul]

Unable to reproduce.

Also the provided code fix actually changes nothing.

[pavimus]

Please take look at CHtml::resolveName function. it can modify $attribute argument, that is passed by reference. In tabular input $attribute is something like '[0]value'. After calling $name=self::resolveName($model,$attribute); $attribute will be changed to 'value'. In non-fixed version if $htmlOptions has no 'for' key, the $attribute will be translated from '[0]value' to 'value', if $htmlOptions has 'for' key - $attribute will stay unmodified, because CHtml::resolveName will not be called.

[klimov-paul]

Issue reproduced.

[klimov-paul]

Solution confirmed

[klimov-paul]

Fix has been prepared. Switching to milestone 1.1.14