Closed wtommyw closed 1 year ago
@marcovtwout @rob006 I tried to request a re-review on both of you, but it looks like Github does not allowe this. I'm unsure if anyon's got the ping now
@wtommyw After https://github.com/yiisoft/yii/pull/4503/files#r1055466147, feel free to add a changelog line with something like : "Enh 4503: Update tests/code for PHP 8.1 compatibility and stop suppressing deprecation warnings"
I still think that cast in
getCanonicalID
is unnecessary andnull
should be handled ingetLocaleDisplayName()
https://github.com/yiisoft/yii/pull/4503/files#r1055466147
@rob006 I agree, I've made the change. This way we'll actually follow the documented behaviour (not passing null into getCanonicalID
.
Re-enabled deprecation errors in tests and fixed them.
Main fixes:
value
;strcmp
,strtolower
,mb_stringtolower
,mb_strpos
and other built in functions being passednull
in tests;assertEquals
uses==
and performs type coercion;null
as an empty string,strlen(null)
is deprecated so a cast is needed;$output
would benull
.