Closed WinterSilence closed 2 years ago
Thanks, it's actually 2 fixes in 1, also handles newlines. :+1:
@arogachev That's method still incorrect. We can detect summary only by first \n\n
, but Yii2 don't use PSR-5.
@WinterSilence Thanks. Moved it to a separate issue for now - #283.
@WinterSilence Thanks for your contribution! :+1: I additionally checked how it affects current API docs using diffs, didn't find any regression. Need to prepare new release now.
@arogachev меня удивляет, что такой популярный и, вышедший много лет назад, фреймворк до сих пор настолько сырой
source comment:
before fix
BaseDoc::extractFirstSentence()
return:a URI [RFC3986](https://tools.
after:a URI [RFC3986](https://tools.ietf.org/html/rfc3986) or URI template [RFC6570](https://tools.ietf.org/html/rfc6570).
is dirty fix, but covering main casesMinor additions for historical purposes by @arogachev.
Newline (only affects HTML code, not visual output):
https://github.com/yiisoft/yii2/blob/2874e070f3ad88c727b1335ba4f4515855bf5f64/framework/base/Controller.php#L48-L52
No space after dot: