search

yiisoft / yii2-app-advanced

Yii 2.0 Advanced Application Template
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
1.66k stars 1.28k forks source link

Codeception/verify v2 update #520

Closed TavoNiievez closed 2 years ago

TavoNiievez commented 2 years ago
Q A
Is bugfix? no
New feature? no
Breaks BC? yes
Tests pass? yes
developedsoftware commented 2 years ago

expect and expect_that is removed in 2.2. Should we update the tests to use verify() which I believe work fine still?

i opened this pull request but closed it #519

TavoNiievez commented 2 years ago

expect() still works.

developedsoftware commented 2 years ago

Sorry you are right / expect_that and expect_not have been removed from 2.2 though so I think the tests need to be updated to account for that….

I have a merge request for this - which works. But it fails in php5 because verify requires php7.

If we drop support for 5 then my PR can be merged in. Until that happens we are locked to verify 1.

TavoNiievez commented 2 years ago

I edited my commit to make it co-authored. I will keep this PR open.

developedsoftware commented 2 years ago

@TavoNiievez https://github.com/yiisoft/yii2-app-advanced/pull/521