search

yiisoft / yii2-app-advanced

Yii 2.0 Advanced Application Template
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
1.66k stars 1.28k forks source link

update to PHP 7.4 and codeception/verify 2.2 #521

Closed developedsoftware closed 2 years ago

developedsoftware commented 2 years ago
Q A
Is bugfix? no
New feature? no
Breaks BC? yes - cannot be run on php 5
Tests pass? yes
Fixed issues none

This pull request is to bump codeception/verify up to 2.2 which requires PHP 7 as a minimum.

developedsoftware commented 2 years ago

Apologies for all these tests failing I am unable to test locally. Can anybody advise what codeception-local.php should contain? I am a bit confused regarding the folder structures...

==== Redirecting to Composer-installed version in vendor/codeception. You can skip this using --no-redirect ====

Included Configuration: common
Building Actor classes for suites: unit

In Yii2.php line 265:

  Yii2 module is not configured!                                               

  The application config file does not exist: /Users/luke.english/NetBeansPro  
  jects/yii/yii2-app-advanced/common/config/codeception-local.php              

build

Done.
samdark commented 2 years ago

No worries about failing tests. As long as these are finally OK, feel free to do as many intermediate commits as you need. Can't help with codeception-local.php :(

themikem commented 2 years ago

Apologies for all these tests failing I am unable to test locally. Can anybody advise what codeception-local.php should contain? I am a bit confused regarding the folder structures...

==== Redirecting to Composer-installed version in vendor/codeception. You can skip this using --no-redirect ====

Included Configuration: common
Building Actor classes for suites: unit

In Yii2.php line 265:

  Yii2 module is not configured!                                               

  The application config file does not exist: /Users/luke.english/NetBeansPro  
  jects/yii/yii2-app-advanced/common/config/codeception-local.php              

build

Done.

This is just loaded by the module here: https://github.com/Codeception/module-yii2/blob/14269d059b8eaedf3d414a673907bd874cd4ed04/src/Codeception/Module/Yii2.php#L288

From the yaml file here: https://github.com/yiisoft/yii2-app-advanced/blob/1f4b6b7eafd0087fd79b991b2639998e1936e68a/common/codeception.yml#L15

It is just rolling up the main & test config files and providing the cookie key for compatibility it appears.

I think the error you're seeing can be fixed by doing a ./init and then choosing the dev environment. That should copy the correct codeception-local.php file into place.

developedsoftware commented 2 years ago

Apologies for all these tests failing I am unable to test locally. Can anybody advise what codeception-local.php should contain? I am a bit confused regarding the folder structures...

==== Redirecting to Composer-installed version in vendor/codeception. You can skip this using --no-redirect ====

Included Configuration: common
Building Actor classes for suites: unit

In Yii2.php line 265:

  Yii2 module is not configured!                                               

  The application config file does not exist: /Users/luke.english/NetBeansPro  
  jects/yii/yii2-app-advanced/common/config/codeception-local.php              

build

Done.

This is just loaded by the module here: https://github.com/Codeception/module-yii2/blob/14269d059b8eaedf3d414a673907bd874cd4ed04/src/Codeception/Module/Yii2.php#L288

From the yaml file here:

https://github.com/yiisoft/yii2-app-advanced/blob/1f4b6b7eafd0087fd79b991b2639998e1936e68a/common/codeception.yml#L15

It is just rolling up the main & test config files and providing the cookie key for compatibility it appears.

I think the error you're seeing can be fixed by doing a ./init and then choosing the dev environment. That should copy the correct codeception-local.php file into place.

Awesome thank you