search

yiisoft / yii2-app-advanced

Yii 2.0 Advanced Application Template
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
1.66k stars 1.28k forks source link

Updated composer depedencies to work with Codeception 5 #523

Closed developedsoftware closed 2 years ago

developedsoftware commented 2 years ago
Q A
Is bugfix? o
New feature? no
Breaks BC? no
Tests pass? unknown
developedsoftware commented 2 years ago

Not sure if this can even be done yet - as codception 5 requires PHP 8.

Yii2 I assume will support PHP 7 for quite some time...should I just close this?

samdark commented 2 years ago

@developedsoftware I think it's possible to allow both. Is there a stable release already?

developedsoftware commented 2 years ago

Yes I believe so. I will look to do that ! Thanks

I always think composer is more linear than it is !

developedsoftware commented 2 years ago

OK this should be good to go now!

developedsoftware commented 2 years ago

Requesting approval if possible.

bizley commented 2 years ago

I'm worried about all the dev dependencies here...

developedsoftware commented 2 years ago

I'm worried about all the dev dependencies here...

No different to 2.0.45?

Just version numbers have been altered to allow for the codeception 5 depedencies.

What would you like me to alter?

bizley commented 2 years ago

I mean ^5.0.0-alpha2 or 9.5.x-dev or dev-codecept5

developedsoftware commented 2 years ago

I mean ^5.0.0-alpha2 or 9.5.x-dev or dev-codecept5

I dont follow?

9.5.x-dev is for phpunit/phpunit?

dev-codecept5 is for codeception/module-yii2 which requires "codeception/codeception": "^5.0.0-alpha2"

which is also the requirement for codeception/codeception in this repo ^5.0.0-alpha2

So to me that all checks out OK? Can you clarify?

developedsoftware commented 2 years ago

I'm worried about all the dev dependencies here...

I know what you mean when you said you worry about them dev dependencies. Yes I agree it would be nice to have a stable releases but there arent any so I am forced to use the dev branches.

See here -> https://github.com/Codeception/Codeception/discussions/6327

Not sure how I can request a new release of the yii2 module - so the dev branch is the only way -> https://github.com/Codeception/module-yii2/releases

samdark commented 2 years ago

Thanks.