yiisoft / yii2-bootstrap

Yii 2 Bootstrap 3 Extension
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
185 stars 193 forks source link

Update 2.1 branch #234

Closed cluwong closed 5 years ago

cluwong commented 6 years ago

Is there an estimation when branch 2.1 will be updated to include latest changes in 2.0 branch? I'm working on a template that uses BS4. However my project (currently using BS3 template) uses bootstrap widgets with new some options not available in 2.1 branch and breaks when switching to the 2.1 branch.

klimov-paul commented 6 years ago

I am sorry, but I am unable to do this. I am not aware of the changes Bootstrap 4 brings and not a CSS expert. Thus I will be unable to resolve code conflicts, which will appear during the merge - I simply unable to decide which code is correct and which is not.

If you DO care about this, you can perform merge yourself:

in case a solid pull request with readable diff will be present, me and my coleages will be able to merge it inside '2.1'.

schmunk42 commented 6 years ago

Please see also https://github.com/yiisoft/yii2-bootstrap/issues/77#issuecomment-369005748

tecnoterabyte commented 6 years ago

Hi, please delete branch 2.1 --> BS4, so there are no conflicts and you can install BS3 yiisoft/yii2-bootstrap, BS4 and yiisoft/yii2-bootstrap4 simultaneously.

samdark commented 6 years ago

You cannot anyway because it's not possible to install two versions of the same package via asset-packagist or fxp.

machour commented 5 years ago

This issue can be closed & branch 2.1 should be removed. We now have yii2-bootstrap4 and yii-bootstrap4