search

yiisoft / yii2-bootstrap

Yii 2 Bootstrap 3 Extension
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
185 stars 193 forks source link

Upgrade to bootstrap 4 #77

Closed samdark closed 5 years ago

cchandel commented 6 years ago

Can't find where this has been covered so ... What's the correct way to move to bootstraps4 from a fresh install of advanced template? I tried replacing yiisoft/yii2-bootstrap with yiisoft/bootstrap4: ~1.0.0 but I get errors that force me to change stability to dev. Yet, I still see only bootstrap.css v3 being included in the pages being served. What am I doing wrong?

Severance commented 6 years ago

@cchandel I'm not sure if you ever got around to fixing that issue; however I may have fixed it myself by modifying the $depends array in AppAsset to point to yii\bootstrap4\BootstrapPluginAsset instead of yii\bootstrap\BootstrapPluginAsset.

It seems to have done the trick and I'm no longer getting bootstrap 3 assets being loaded.

machour commented 5 years ago

Can be closed

simialbi commented 5 years ago

@samdark , @machour for backwards compatibility, we may add

    "provide": {
        "yiisoft/yii2-bootstrap": "2.1"
    },

to yiisoft/yii2-bootstrap4/composer.json

samdark commented 5 years ago

Not needed. 2.1 was never released.