search

yiisoft / yii2-bootstrap4

Yii 2 Bootstrap 4 Extension
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
216 stars 106 forks source link

[Work In Progress] Attempt to fix #133 #143

Closed YiiRocks closed 5 years ago

YiiRocks commented 5 years ago
Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #133

Needs further testing before merge

samdark commented 5 years ago

Merged. Thank you!

samdark commented 5 years ago

Reverted it.

YiiRocks commented 5 years ago

Hi @samdark

Do you know the best way to update my fork from master and apply these changes again for PR?

samdark commented 5 years ago

Updating is easy: https://github.com/yiisoft/yii2/blob/master/docs/internals/git-workflow.md#7-pull-the-latest-yii-code-from-upstream-into-your-branch

To apply changes one more time something like hub am can solve it.