search

yiisoft / yii2-bootstrap4

Yii 2 Bootstrap 4 Extension
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
216 stars 106 forks source link

FEATURE Bootstrap Collapse support #187 #188

Closed dshiryaev-plesk closed 4 years ago

dshiryaev-plesk commented 4 years ago
Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass?
Fixed issues #187
simialbi commented 4 years ago

Why? It exists: https://github.com/yiisoft/yii2-bootstrap4/blob/master/src/Accordion.php

schmunk42 commented 4 years ago

Why? It exists: https://github.com/yiisoft/yii2-bootstrap4/blob/master/src/Accordion.php

I think a Collapse is for a single panel, while an accordion is for multiple? https://getbootstrap.com/docs/4.3/components/collapse/#example

simialbi commented 4 years ago

According the comment no, both are accordions. That's why I renamed the class from Collapse to Accordion when we started to create bs4 repository from bs3 one: https://github.com/yiisoft/yii2-bootstrap4/pull/188/files#diff-d26b3b1cb47b86484c8db442084dd915R14

samdark commented 4 years ago

Oh :)

Thanks, @simialbi :)

And thank you, @dshiryaev-plesk for the pull request.

dshiryaev-plesk commented 4 years ago

Thanks for the explanation.

dshiryaev-plesk commented 4 years ago

The Accordion class name is confusing because there is no Accordion component in Bootstrap 4: https://getbootstrap.com/docs/4.4/components/collapse.

simialbi commented 4 years ago

Yeah what you link here is not the accordion. It's the collapse, it's used in many ways in bootstrap. The accordion itself is called accordion in bootstrap too: https://getbootstrap.com/docs/4.4/components/collapse/#accordion-example