search

yiisoft / yii2-bootstrap4

Yii 2 Bootstrap 4 Extension
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
216 stars 106 forks source link

Fix show error for checkbox, radio, checkboxList, radioList #208

Closed egrekov closed 3 years ago

egrekov commented 3 years ago
Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #173
bizley commented 3 years ago

Can we get some unit tests for this?

samdark commented 3 years ago

Looks like tests are failing...

egrekov commented 3 years ago

Looks like tests are failing...

Yes, I'll deal with the tests a little later, it's bad that they don't run locally, it would be easier.

samdark commented 3 years ago

Don't run locally? Why?

samdark commented 3 years ago

Update from master. It may help (in case you're under Windows).

egrekov commented 3 years ago 
root@516debc04af8:/opt/app# vendor/phpunit/phpunit/phpunit --filter ActiveFieldTest
PHPUnit 4.8.34 by Sebastian Bergmann and contributors.

Runtime:        PHP 7.3.27
Configuration:  /opt/app/phpunit.xml.dist

.............

Time: 2.62 seconds, Memory: 8.00MB

OK (13 tests, 13 assertions)
bizley commented 3 years ago

Please add CHANGELOG entry and it should be good to go.

egrekov commented 3 years ago

Please add CHANGELOG entry and it should be good to go.

And how to write correctly and in which block?

-2.0.10 under development
+2.0.10 March 04, 2021
 ------------------------

 - Enh #205: Added `Toast` widget (simialbi)
-
+- Bug #173: Fix show error for checkbox, radio, checkboxList, radioList

 2.0.9 November 10, 2020
 -----------------------
bizley commented 3 years ago

Don't change the date, just add new line under Enh #205: Added Toast widget (simialbi) with something like: - Bug #173: Fix bug with error messages not being displayed for checkbox, radio, checkboxList, and radioList (egrekov)

egrekov commented 3 years ago

Ok, CHANGELOG updated

samdark commented 3 years ago

Thanks!