Checkbox labels should not be hidden in inline forms

yiisoft / yii2-bootstrap4

Yii 2 Bootstrap 4 Extension

https://www.yiiframework.com/

BSD 3-Clause "New" or "Revised" License

216 stars 106 forks source link

Checkbox labels should not be hidden in inline forms #243

Closed BBoom closed 7 months ago

BBoom commented 7 months ago

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues

Inline forms by default hide all labels with the sr-only class. This should not happen for checkbox elements, which need their label to function. Without a visible label, the checkbox will not function in bootstrap. And even if it did, a checkbox without a label is not really usable.

The method for class removal is based on similar exceptions made in the listBox() and dropDownList() methods in the same class.

samdark commented 7 months ago

Good one. Please add a line for CHANGELOG. Thanks.

BBoom commented 7 months ago

Thanks! I've added a log entry @samdark

samdark commented 7 months ago

Thanks!