Tag release

[samdark]

@simialbi I've added a package to packagist. Is it ready to be tagged 1.0.0?

[simialbi]

@samdark I'll crosscheck today and will give the ok afterwards

[simialbi]

Should be ok to go with 1.0.0

[samdark]

@bizley would you please do extra read before tagging it?

[bizley]

1. https://github.com/yiisoft/yii2-bootstrap5/blob/master/.github/workflows/build.yml - we need to test on php 5.4+
2. Guides need to be updated but we can do it later on (or now?).
3. Code has PHP 7+ features so if we don't plan to support older versions it's fine, otherwise it needs downgrading.

[samdark]

Docs should be up to date for certain.

[simialbi]

1. Supporting php >=7.0 is discussable, php 5.4, 5.5, 5.6 is imho outdated
2. I updated the class names, added new widgets, and removed a big part of the migration guide (difference between bs4 and bs5 is not as big as bs3 to bs4)
3. See 1

[bizley]

I'm all for using newest PHP versions but it's Yii 2 and people still using it on 5.x.

[bizley]

[simialbi]

ok, but I think nearby all of them are using bs3. Compared to yii2-bootstrap4 statistics there are just some 5.6er:

[bizley]

If this is valid argument we would get rid of 5.x support in Yii 2, wouldn't we? ;)

[simialbi]

I would agree immediately 😊😉. But I know what you mean. We need a decision here. @samdark ?

[samdark]

3.6% total. That means there are alive Yii 2 projects on v5.

[simialbi]

Means make the repository 5.4+ compatible?

[samdark]

I've meant that regarding framework package itself. Having different constraints for this package is alright since majority of new projects are started with at least PHP 7.

[bizley]

Ok, so only guide needs some updates.

[simialbi]

ok, I downgraded the code so it works with php >=7.0 and updated the docs (the languages I understand)

[simialbi]

I think now we could release 1.0.0? @samdark , @bizley ?

[bizley]

To be updated yet:

• https://github.com/yiisoft/yii2-bootstrap5/blob/master/docs/guide/assets-setup.md#using-bowernpm-client-directly (dependencies)
• https://github.com/yiisoft/yii2-bootstrap5/blob/master/docs/guide/basic-usage.md (link to docs)
• https://github.com/yiisoft/yii2-bootstrap5/blob/master/docs/guide/usage-widgets.md#navbar-widget- (doc link)
• https://github.com/yiisoft/yii2-bootstrap5/blob/master/docs/guide/helper-html.md (static controls link)

BTW looks we miss the chance to support 5.1.0 from the very beginning. Or maybe?

[simialbi]

Thanks for your feedback. I updated docs. What do you mean with miss the chance to support 5.1? I think there are not widget related changes. The biggest one imho is the Offcanvas in Navbar, and that's possible after last commit:

NavBar::begin([
    'brandLabel' => 'Offcanvas navbar',
    'brandUrl' => ['/'],
    'options' => [
        'class' => ['navbar', 'navbar-light', 'bg-light', 'fixed-top']
    ],
    'innerContainerOptions' => [
        'class' => ['container-fluid']
    ],
    'collapseOptions' => false,
    'offcanvasOptions' => [
        'title' => 'Offcanvas',
        'placement' => Offcanvas::PLACEMENT_END
    ]
]);
echo Nav::widget([
    'options' => [
        'class' => ['navbar-nav']
    ],
    'items' => [
        ['label' => 'Home', 'url' => '#'],
        ['label' => 'Link', 'url' => '#'],
        ['label' => 'Dropdown', 'items' => [
            ['label' => 'Action', 'url' => '#'],
            ['label' => 'Another action', 'url' => '#'],
            '-',
            ['label' => 'Something else here', 'url' => '#'],
        ]]
    ]
]);
NavBar::end();

[bizley]

Great. So just updating version in the docs and we are good to go.

[simialbi]

ok, docs are ready

[bizley]

Green light @samdark

[samdark]

Done. Thanks for preparing it!

[antichris]

FYI, composer does not work this way https://github.com/yiisoft/yii2-bootstrap5/blob/5c642f8811dafcafc88d15cfb4ceb2a3ec1df5c7/composer.json#L4 (tagged as 2.0.0)

The common practice is omitting version altogether to rely on VCS markers instead.

(yii2-bootstrap5/composer.json at 2.0.0 · yiisoft/yii2-bootstrap5)

(version - The composer.json schema - Composer)

[antichris]

Could we, please, get a new release sometime soon?

1. It's been a while since the previous one,
2. there are no outstanding issues at the moment (actually, projects often do periodic releases even when there are unresolved issues), and
3. people may actually be waiting for current bugfixes to be released — I know I am.

[samdark]

Sure.

[samdark]

Done.