search

yiisoft / yii2-collection

Collection extension for Yii 2
BSD 3-Clause "New" or "Revised" License
67 stars 19 forks source link

Collection: use ArrayAccessTrait, clone objects #23

Closed WinterSilence closed 3 years ago

WinterSilence commented 3 years ago
Q A
Is bugfix? yes
New feature? no
Breaks BC? yes/no
Tests pass? yes
Fixed issues
bizley commented 3 years ago

There are serious BC breaks in class signature and constructor, we cannot make changes like that.

WinterSilence commented 3 years ago

@bizley list of BC please

bizley commented 3 years ago

Removing interfaces, removing default $data value from constructor.

WinterSilence commented 3 years ago

@bizley

Removing interfaces

my fail - fixed

removing default $data

it's not BC and default value in this case is unusable

bizley commented 3 years ago

it's not BC and default value in this case is unusable

It is, previously you could instantiate new object without providing $data, now you have to. This is BC break, I don't comment on the usefulness of not providing the $data though.

WinterSilence commented 3 years ago

@bizley it's "draft" package, what are we even talking about?

bizley commented 3 years ago

True ;)

samdark commented 3 years ago

👍