search

yiisoft / yii2-debug

Debug Extension for Yii 2
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
202 stars 150 forks source link

Fixes in "Since previous" column's value calculation #411

Closed Ir00man closed 5 years ago

Ir00man commented 5 years ago

Due to differences in how DateInterval::format() works in different PHP versions we need to replace it for simple math.

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #409
Ir00man commented 5 years ago

Looks good to me. Can you add a line for changelog?

Where should I add it?

I guess Fixed "Since previous" column's value calculation will be a good one.

samdark commented 5 years ago

https://github.com/yiisoft/yii2-debug/blob/master/CHANGELOG.md

Ir00man commented 5 years ago

@samdark should it be done with another PR?

samdark commented 5 years ago

No. Just push additional commit to the same branch.

Ir00man commented 5 years ago

Oh, nice, didn't know that this could work this way

samdark commented 5 years ago

Merged. Thank you!