search

yiisoft / yii2-debug

Debug Extension for Yii 2
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
202 stars 150 forks source link

Fix import yii\helpers\Html in DumpPanel #427

Closed zhukovra closed 4 years ago

zhukovra commented 4 years ago
Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️
Fixed issues

I don't know how it was working without importing class: https://github.com/yiisoft/yii2-debug/blob/3faaa0d6a8ee7592f23f0962496773d1d9ead0b0/src/panels/DumpPanel.php#L120

Can be tested with:

        $panel = new DumpPanel([
            'highlight' => false,
        ]);
        $panel->varDump('');

but I'm not sure that the tests needs to be written for that.

samdark commented 4 years ago

It's valid one. Good catch 👍 Please add a line for changelog. Thanks.

zhukovra commented 4 years ago

@samdark changelog added.

samdark commented 4 years ago

Merged. Thanks!