search

yiisoft / yii2-debug

Debug Extension for Yii 2
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
201 stars 149 forks source link

Update Module.php to fix assets register #464

Closed niciz closed 4 months ago

niciz commented 2 years ago

Register assets using the yii\web\View functions. In my application I have override the standard yii\web\View in order to add CSP nonce to each scripts loaded with View functions. Unfortunately yii-debug module doesn't use those functions to load assets. This is the fix.

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues none
samdark commented 2 years ago

@niciz that breaks these special cases when asset manager isn't available.

samdark commented 1 year ago

@niciz I haven't seen extra commits. Now it looks alright. Would you please add a line for CHANGELOG? Thanks.

samdark commented 1 year ago

Also please merge master into your branch.

niciz commented 1 year ago

Hi @samdark sorry for late reply. Yes I fixed it and currently I'm using it in production without problems. Merged and added changes to CHANGELOG.md

Let me know if you need something else.

samdark commented 1 year ago

Seems tests are broken because of the changes. Would you please check these?