search

yiisoft / yii2-debug

Debug Extension for Yii 2
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
201 stars 149 forks source link

Using symfonymailer instead of swiftmailer #468

Closed developedsoftware closed 2 years ago

developedsoftware commented 2 years ago

Replace swiftmailer with symfonymailer There is a reference to swiftmailer inside MailPanel.php but I believe that has to stay for BC. I assume symfonymailer does not required any conditional code so I have not edited this. Simply change really ! LOL | ------------- | --- | Is bugfix? | ❌ | New feature? | ✔️ | Breaks BC? | ❌ | Fixed issues | #467

samdark commented 2 years ago
  1. Seems to break tests.
  2. It is require-dev dependency so doesn't affect production.
  3. We won't be able to run tests on older versions when using new mailer.
developedsoftware commented 2 years ago

Yes I just see that symfonymailer requires 7.4 - and thats the only test it passes on.

No problem, cannot be merged in that case then. Stuck with swiftmailer until yii2 requires 7.4 right (which is in progress I believe?)

samdark commented 2 years ago

which is in progress I believe?

There's no real reason to up the requirement.