search

yiisoft / yii2-debug

Debug Extension for Yii 2
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
201 stars 149 forks source link

Fix PHP 8.1 warning (implicit conversion from float to int loses precision) #476

Closed mishamosher closed 2 years ago

mishamosher commented 2 years ago

I've been unable to open the logs, profiling, and database panels on PHP 8.1, which greet me with a deprecation notice:

GH_YII2_DEBUG

This PR intends to resolve such issue.

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #470
samdark commented 2 years ago

Please add a line for changelog. Thanks.

mikehaertl commented 2 years ago

@samdark @bizley Is this ready for merge? Would be great to have these last bugs for PHP 8.1 fixed.

bizley commented 2 years ago

LG to release @samdark

mikehaertl commented 2 years ago

@bizley There's also still #475 ...

mishamosher commented 2 years ago

475 is solved by #472

https://github.com/yiisoft/yii2-debug/pull/472/files#diff-7542d6b0bc96b516d7de81558490efc4b9c4afba3178668a105ed9881e4a2ebc

Don't know why it has an extra PR.

bizley commented 2 years ago

True

mikehaertl commented 2 years ago

@mishamosher Oh, right. Thanks for the pointer. Then a release should be fine.

mishamosher commented 2 years ago

Glad it got sorted out (:

Been waiting a while for a now working master branch under PHP 8.1 🎉

bizley commented 2 years ago

Yes, please use master and be patient while waiting for a proper release. We are living in a trying times now...