search

yiisoft / yii2-debug

Debug Extension for Yii 2
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
202 stars 149 forks source link

Future add data source #489

Open evgenybukharev opened 2 years ago

evgenybukharev commented 2 years ago
Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
evgenybukharev commented 2 years ago

Another debug data storage support

yii-bot commented 2 years ago

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

Unfortunately a use case is missing. It is required to get a better understanding of the pull request and helps us to determine the necessity and applicability of the suggested change to the framework.

Could you supply us with a use case please? Please be as detailed as possible and show some code!

Thanks!

This is an automated comment, triggered by adding the label pr:missing usecase.

evgenybukharev commented 2 years ago

The functionality of data storage of the debug panel is implemented not only in file storage, an interface has been added that allows users to implement any convenient storage for data, whether it is a database or redis. The cache data storage is also implemented

sorry for my english

https://github.com/yiisoft/yii2-debug/issues/73

SamMousa commented 1 year ago

I like the idea of this PR but I'm not convinced on the architectural choices.

In my opinion storing data is the task of a log target. By limiting your changes only to a new LogTarget we don't have to break BC which is a big win.

Also I don't see the benefit of introducing a new interface, which will see few implementors. Instead just tie this to our CacheInterface and any implementor can easily implement that.

My unfinished proof of concept: https://github.com/yiisoft/yii2-debug/issues/495 achieves similar functionality with just a new target. Meaning no BC break.

Also this PR suffers from the same shortcoming as my PoC for mail files: they are still stored on disk. For the mail files I'll create a new issue since maybe we can solve that outside of this one.

evgenybukharev commented 1 year ago

@samdark Hi, I added line to CHANGELOG and added instructions to README

bizley commented 1 year ago

And we need tests.

yii-bot commented 1 year ago

Thank you for putting effort in the improvement of the Yii framework. We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.