search

yiisoft / yii2-docker

Official Docker images suitable for Yii 2.0
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
384 stars 202 forks source link

ci: add action to build docker images #107

Closed odai-alali closed 3 years ago

odai-alali commented 3 years ago

closes #106

schmunk42 commented 3 years ago

I think we need to add an error variable for the commands in test stage, eg.

docker-compose ..... || ERROR=1
...
exit ERROR

So a broken Xdebug installation would also fail.

and we should also have 8.0 with allowed to fail.

odai-alali commented 3 years ago

php 5 is failing as expected now. Pushing happens only on master and tag.

Check it out. It can be enhanced I think (takes a lot of time)

odai-alali commented 3 years ago

I think we need to add an error variable for the commands in test stage, eg.

docker-compose ..... || ERROR=1
...
exit ERROR

So a broken Xdebug installation would also fail.

and we should also have 8.0 with allowed to fail.

BTW, this was not needed. When the test fails, the step after it will not be executed without evaluation variable

samdark commented 3 years ago

Merged. I don't have any additions.