yiisoft / yii2-docker

Official Docker images suitable for Yii 2.0
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
381 stars 202 forks source link

Composer Error `Your github oauth token for github.com contains invalid characters` #136

Closed Alex-DA closed 3 years ago

Alex-DA commented 3 years ago

Hello, it seems that GitHub changed the format of their auth tokens and this break with our current composer version.

We need to upgrade to composer >= 2.0.12 at https://github.com/yiisoft/yii2-docker/blob/c29f89e9f57876c1f4cdc935a762d5e11a9147de/php/Dockerfile-debian#L47

More info:

samdark commented 3 years ago

@Alex-DA do you have time for a pull request?

Alex-DA commented 3 years ago

Hello @samdark , this is my first PR https://github.com/yiisoft/yii2-docker/pull/137

Also I saw it this other things:

  1. MacOS comment on Readme If you are using macOS, you can fill xdebug.remote_host with host.docker.internal, due to a network limitation on mac but if you check the configuration file of xdebug is already using host.docker.internal

https://github.com/yiisoft/yii2-docker/blob/c29f89e9f57876c1f4cdc935a762d5e11a9147de/php/image-files/usr/local/etc/php/conf.d/xdebug.ini#L6

Can I delete that comment in the same PR?

  1. ENV var about Prestissimo

https://github.com/yiisoft/yii2-docker/blob/c29f89e9f57876c1f4cdc935a762d5e11a9147de/php/Dockerfile-debian#L35

But the prestissimo is not needed anymore on composer 2... This plugin is for Composer1; Composer2 is very fast on its own. Uninstall this plugin and update the Composer itself. +info https://github.com/hirak/prestissimo

Can I delete that line in the same PR?

samdark commented 3 years ago

Can I delete that comment in the same PR? Can I delete that line in the same PR?

Yes.

Alex-DA commented 3 years ago

Ok, done.

samdark commented 3 years ago

Merged. Thanks. Images should be automatically prepared by GitHub actions currently running.